Re: [gtk-list] Re: Patch: (radio|check)menuitem, list.

[johannes nada kth se (Johannes Keukelaar)]

Peter Mattis writes:

//Johannes Keukelaar writes:
//
//>1 & 2): radiomenuitems and checkmenuitems would only show their `dimple'
//>when they're either selected or prelighted (i.e. have the mouse over them)
//>in the current version of gtk+. This patch makes them always show their
//>dimple, and the appropriate one (i.e. in or out) when they are prelighted.
//
//Um, it was not a bug for radio and check menu items to only show their
//dimple when selected or prelighted. That was there by design as that
//is basically the way motif works. (Actually, motif only shows the
//dimple when a menu item is selected). 
//
//I prefer not to have the dimples always shown as this would make a
//menu like the "Go" menu in Netscape fairly ugly. I'm open to arguments
//one way or another, but please (CVS folks) don't simply apply this
//patch blindly.

Well, I didn't know it was a design decision rather than a bug. My apologies 
for that. Allow me to argue my case.

Having just run Netscape (3.0.1) here on my Sun (with Sun's Motif library), I 
see that the Options menu, for example, is full of dimples that are shown 
regardless of whether or not the mouse is over the item. The Go menu, on the 
other hand only shows a dimple on the selected item (and it's a check menu item 
dimple, not a radio menu item dimple, while the choice is exclusive). 
Apparently this is configurable on an item-by-item basis, then, in Motif. If 
you think it should be configurable in gtk, as well, I would be happy to 
provide an alternative patch that would arrange for that. (In that case, what 
should be the default behaviour?)

My current patch toggles the dimples when the mouse is over the item; Motif 
does not do this. Which is the desired behaviour?

Why should it be configurable at all (rather than only showing a dimple when 
selected)? Well, I personally feel that it's confusing when the dimples don't 
show all the time, because then it just looks like a menu item with some space 
in front of it. ('What's this? A menu item called '  Show Menubar', a check 
menu item or a radio menu item?') Just my two cents.

//Of course, the second part of the patch dealing with keyboard
//selection of list items is much appreciaited. (I'd just never gotten
//around to fixing it myself).

Well, the rest of Gtk is also very appreciated. Thanks!

//Peter

Johannes.
--
A tidy room is the sign of a sick mind.

Gathering Magician in a Magic-less world?