Re: Merging code between Xft and FT2 shapers

[Tony Graham <Tony Graham Sun COM>]

Owen Taylor wrote at 14 Apr 2003 07:40:29 -0400:
 > I finally got tired of having duplicated code in:
 > 
 >  - arabic-ft2 and arabic-xft
 >  - basic-ft2 and basic-xft
 >  - hebrew-ft2 and hebrew-xft
 > 
 > with patches for thai-ft2 and indic-ft2 outstanding.
 > So, what I decided to do was create a PangoFcFont (*) base
 > class with virtual functions such as:
 > 
 > FT_Face    pango_fc_font_lock_face (PangoFcFont *font);
 > gboolean   pango_fc_font_has_char  (PangoFcFont *font,
 >                                     gunichar     wc);
 > 
 > This allows the very same code to be used for both the
 > Xft and FT2 backend.

Sounds good to me (since I have potentially two extra variants of each
module).

Would you also consider making a base class for the common font map
functionality in pangofc-fontmap.cI?

Regards,


Tony Graham
------------------------------------------------------------------------
XML Technology Center - Dublin
Sun Microsystems Ireland Ltd                       Phone: +353 1 8199708
Hamilton House, East Point Business Park, Dublin 3            x(70)19708