Re: Putback thai.c to CVS

Chookij Vanatham <chookij vanatham eng sun com> writes:

> Hi Owen,
> Thanks for the review.
> I'll update the fix.
> Regarding the main question about 0x7F glyph, it's the black box glyph which
> defines from Thai microsoft window for the case of illegal sequence.
> It's zero-width and negative advance witdth. Then, in Thai MS, what they
> want to display is just displaying this black box glyph overwrite or on top
> of the previous cluster (cell).
> We don't think this is the good idea to display the Black box like that,
> so, we change the glyph to be like "blank or space" with positive advance width
> and non-zero width. The way, the display will look better.
> Not quite sure about what your concern is. Let me know more detail and I'll
> check it out.

I was just wondering what the effect of the code was, since it wasn't
obvious for me not having the fonts in front of me.

As long as the actual width (the amount the x-origin is advanced) of
the character is non-negative, there is no problem. 

Since 0x7f is ASCII delete, I just wanted to make sure that this
character didn't move the x-origin backwards, since I think that would
break a lot of code in Pango.

Sounds fine the way you describe it,

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]