Re: [Fwd: *Another* gtk-doc patch...]

[Owen Taylor <otaylor redhat com>]

Damon Chaplin <damon ximian com> writes:

> Here's a patch I got for gtk-doc.
> It looks reasonable (although of course it should be for gtkdoc-mkdb.in)

Actually, I don't understand this patch. As far as I can tell, the
basic effect is to omit the warning if the "last" line of the
enumeration declaration is unparseable.

I wouldn't want to add this patch, since it has the effect of
hiding parsing errors - I think a more specific patch
is needed. Of course, that would require knowing what error
this was supposed to fix. (Perhaps I'm just missing something
obvious about this patch.)

And of course, the identical copy in gtkdoc-mktmpl.in needs to
be changed as well if ParseEnumDeclaration is changed.

Regards,
                                        Owen

> Shall I commit?
> 
> I'll do a new release after this.
> 
> Damon
> 
> 
> > --- gtkdoc-mkdb.orig    Sat Mar 10 17:18:26 2001
> > +++ /usr/bin/gtkdoc-mkdb        Sun Mar 11 10:28:55 2001
> > @@ -2268,11 +2268,12 @@
> >         } elsif ($line =~ m/^#include/) {
> >             last;
> > 
> > +       } elsif ($terminator eq '}') {
> > +           last;
> > +
> >         } else {
> >             warn "Cannot parse enumeration member $line";
> >         }
> > -
> > -       last if $terminator eq '}';
> >      }
>
> From: Yoann Vandoorselaere <yoann mandrakesoft com>
> Subject: *Another* gtk-doc patch...
> To: Damon Chaplin <damon ximian com>
> Date: 13 Apr 2001 12:39:47 +0200
> 
> 
> Hi,
> 
> Attached is a fix for a problem with enumeration parsing...