Re: RFC: String cleanup

[Tim Janik <timj imendio com>]

On Fri, 16 Dec 2005, Daniel Marjamäki wrote:

> Hello friends!
>
> I'm new to GTK, and would like to contribute. I have an idea for what I can do...
>
> Changing from:
>  [const] char *str
> to:
>  [const] char str[]
> is often (but not always) a good idea because the latter is a more direct approach, saving both cpu and memory.
>
> There are lots of places in GTK where I could make this change.
>
> Any comments?

yes, thanks for your enthusiasm ;)

strings for which you do this should always be declared static,
otherwise it'd be an ABI change.
also, in pretty much all cases, there should be a "const" in the code
already.

apart from that, just go ahead and start submitting patches in
digestible sizes (say a few hundred lines). preferrably with ChangeLog
already, so all we need to do is: read, apply, compile, commit ;)

> Best regards,
> Daniel Marjamäki

---
ciaoTJ