some things in GTK+ 2.7.5

[Benoit Carpentier <gtkool_2kx yahoo fr>]

Hi everybody,

Some questions and remarks about files of GTK+ 2.7.5 :

in GTK+ 2.7.5\gtk\gtkvpaned.c

lines 199 to 209 :

  if (GTK_WIDGET_MAPPED (widget) &&
	  paned->child1->allocation.height <
child1_allocation.height)
	{
	  gtk_widget_size_allocate (paned->child2,
&child2_allocation);
	  gtk_widget_size_allocate (paned->child1,
&child1_allocation);
	}
      else
	{
	  gtk_widget_size_allocate (paned->child1,
&child1_allocation);
	  gtk_widget_size_allocate (paned->child2,
&child2_allocation);
	}

why is the order of allocating paned->child1 and
paned->child2 important here ?


in GTK+ 2.7.5\gtk\gtkrc.c

twice the same lines, lines 2558 and 2560 :

         token = g_scanner_get_next_token (scanner);
      
         token = g_scanner_get_next_token (scanner);

is this correct ?


in GTK+ 2.7.5\gtk\gtkcheckmenuitem.c

lines 441 to 444 we have :

      offset = GTK_CONTAINER
(check_menu_item)->border_width +
widget->style->xthickness;
      
      offset = GTK_CONTAINER
(check_menu_item)->border_width +
widget->style->xthickness + 2; 

is the first offset = ... really necessary here ?


in GTK+ 2.7.5 in modules\engines\ms-windows,  in
msw_style.c, line 785 :

  /* Default forgeground */
this might be "foreground" here

Benoît Carpentier, "GTKool"


	

	
		
___________________________________________________________________________ 
Appel audio GRATUIT partout dans le monde avec le nouveau Yahoo! Messenger 
Téléchargez cette version sur http://fr.messenger.yahoo.com