Re: [patch-request] GtkCellRendererText documentation



On Sat, 2004-09-11 at 14:56, Sven Herzberg wrote:
> Hi,
> 
>   may I submit this patch?
> http://blaubeermuffin.de/stuff/gtk-add-cellrenderertext-signal-edited-explanation.patch

Well, certainly you may submit a patch similar to that in bugzilla
(we never object to patches), though:

 - Signals are generally documented inline; see examples in 
   gtkcellrender.c
 - You should use meaningful names rather than @arg1, @arg2;
   the names you use in the docs will appear in the output;
   you probably want to use the names in GtkCellRendererTextClass
 - While you are at it, perhaps you'd actually like to document
   the signal fully rather than just it's parameters? When
   is it emitted? how is it used by an application?

Thanks for the contribution, 
					Owen

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]