table menu api change



Hi,

dynamic menus are currently a bit broken due to the table menu changes,
and there are also problems with the way in which gtk_menu_insert/remove
operate on table menus (see bug 130370). 

I think the cleanest way to fix this is to restrict the "old" functions
(insert/remove/append/prepend) to work only on regular (single column)
menus, and let table menus be handled with gtk_menu_attach. This would
require to add a "detach" counterpart so that people can remove stuff
from table menus. Unfortunately, the name gtk_menu_detach() is already
used and means something completely unrelated (which already implies
that the name gtk_menu_attach was badly chosen). 

Therefore, I'd like to change gtk_menu_attach to gtk_menu_attach_item
and add gtk_menu_detach_item to go with it. 

The only user of the table menu api which would be affected by this
change seems to be libgnomeprintui.

Opinions ?

Matthias




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]