Re: GtkFileFilter

[Owen Taylor <otaylor redhat com>]

On Wed, 2004-02-18 at 22:50, Jan Arne Petersen wrote:
> Hi,
> 
> in the current Filechooser implementation there is a problem with the
> GtkFileFilter if you first add the filter to a chooser and than add a
> pattern to the filter:
> 
> filter = gtk_file_filter_new ();
> gtk_file_chooser_add_filter (chooser, filter);
> gtk_filter_add_pattern (filter, "*.foo");
> 
> The problem is that the file list is filtered in the add_filter function
> and the filter doesn't notify about changes, so the pattern is ignored
> till another folder is selected or another filter is selected (see for
> example http://bugzilla.gnome.org/show_bug.cgi?id=128396). 
> 
> Should we document this problem or add a "changed" signal to
> GtkFileFilter?

Document, in my opinion, or perhaps even enforce (a GTK+ internal
_gtk_file_filter_lock() or something). But probably just documenting
is OK.

Unless you have a good use case for why changing an existing filter
is going to be a common operation.

Regards,
						Owen