Re: GtkFileSystemGnomeVFS
- From: Owen Taylor <otaylor redhat com>
- To: Alexander Larsson <alexl redhat com>
- Cc: Federico Mena Quintero <federico ximian com>, "gtk-devel-list gnome org" <gtk-devel-list gnome org>
- Subject: Re: GtkFileSystemGnomeVFS
- Date: Wed, 18 Feb 2004 09:58:39 -0500
Hmm, couple of things I didn't notice last time:
"file-system" should be changed to "file-system-backend" to match
the property name "File System Backend" - these always match.
Similarly the enumeration should be changed, and I'd rename the
parameter to your new set_file_system(), since I think it is
confusing to have 'file_system' be a backend name not a
GtkFileSystem
But other than that, fine with me to commit. Perhaps Federico wants
to take a look.
Regards,
Owen
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]