Re: Patch to make Pango use Automake 1.7

[Owen Taylor <otaylor redhat com>]

On Sun, 2003-03-09 at 06:33, James Henstridge wrote:
> I have written a patch to get the HEAD branch of Pango to use Automake 
> 1.7.  It is attached to the following bug:
>     http://bugzilla.gnome.org/show_bug.cgi?id=107913

OK, I've read through it all and it looked pretty good. 

(I wouldn't be surprised if I missed something ... my eyes glazed
over pretty hard when I got to all the modules/*/Makefile.am
changes, but all the changes looked good in principle.)

The only things I noticed were one typo:

 +dnl I would use AC_HELP_STRING here, but due to some bugs in
m4_text_wrap,
+dnl it interprets the commas in incorrectly ...

And docs/Makefile.am had:

+AUTOMAKE_OPTIONS = 1.6

Which I wasn't sure was intentioal, or supposed to be '1.7' now.

We probably need to do a bit of testing of this ... it would be
very easy to get HAVE_X/HAVE_XFT mixed up in some place
or something like that.

What would make sense to me would be to try tow things:

 - Try building without Xft (should be easy enough ... just 
   move the Xft.pc file out of the way temporarily)

 - Try building with --with-included-modules. (It wouldn't
   be surprising if this is broken for some other reason
   though ... it's reasonably fragile and not tested much.)

I can try to remember to do this after you check in if you
want.

> It also includes a number of makefile cleanups that were made possible 
> because of new features in Automake 1.7.

pango/Makefile.am certainly looks a lot prettier with your changes.

Regards,
                                       Owen