Re: stranges things in gtkbox.h



On Mon, Apr 07, 2003 at 12:46:46PM -0700, Evan Martin wrote:
> On Mon, Apr 07, 2003 at 09:24:48PM +0200, David Odin wrote:
> >   - spacing and homogeneous are declared public even if they have
> >     accessors which should really be used.
> 
> Changing this would break backwards compatibility.
> The accessors *should* be used, but if a program uses those members
> directly it shouldn't suddenly break.
> 
  Sure, but shouldn't the comment just above be changed to /*< private >*/

  The /*< public >*/ comment just encourages people to use these fields
directly.  Unless this is used as a marker for the language bindings, it
should be changed, imho. And even so, a comment should tell C/C++ people not to use these fields.

        Regards,

               DindinX

-- 
david dindinx org
main(int n,char**a){for(n=0;putchar(a[2][n]?(a[2][n]%32+(**a%2*2-1)*
(a[1][n++%(a[2]-a[1]-1)]%32-1)+25)%26+97:10)-10;);}



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]