Re: My take icon icon resizing

I seem to be getting credit here for something I did not do. It was either Bill 
or Brian who wrote the original patch in question.


> Attached is my take on changing the stock icon sizes; it's
> basically a complete rewrite from Padraig's patch in:
> Major differences include:
>  - Since icon sizes are set from a GtkSettings setting,
>    they have to be per-GtkSettings object. To this end,
>    I added:
>     gboolean gtk_icon_size_lookup_for_settings (GtkSettings *settings,
> 					        GtkIconSize  size,
> 					        gint        *width,
> 					        gint        *height);
>    And the per-settings sizes are stored attached to
>    the GtkSettings object.
>  - I changed the string format from "gtk-menu 30,30:gtk-dialog 40,40"
>    to "gtk-menu=30,30:gtk-dialog=40,40", since it seemed a little
>    clearer with an explicit delimiter character.
>  - I changed the string parser from being heuristic to validating.
>    (Using some string scanning utilities from Pango rather than 
>    than strsplit()/atoi())
>  - I organized things so as much of the logic as possible lived
>    in gtkiconfactory rather than slopping over into gtkrc.c
>    (I made one private API addition to gtkrc.c - _gtk_rc_reset_styles()
>    that resets all the styles so everything resizes; I wrote
>    the function originally for some 
>    change-font-rendering-options-on-the-fly patches.)
> It seems to work in testing and I think it's basically the right
> way to go about things. There maybe a little more cleanup to
> do, but other than that I think it's ready to go in.
> Regards,
>                                         Owen

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]