Re: My take icon icon resizing
- From: Owen Taylor <otaylor redhat com>
- To: Brian Cameron <Brian Cameron sun com>
- Cc: calum benson sun com, bill haneman sun com, markmc sun com, gtk-devel-list gnome org
- Subject: Re: My take icon icon resizing
- Date: Tue, 1 Oct 2002 12:25:55 -0400 (EDT)
Brian Cameron <Brian Cameron sun com> writes:
> Owen & Others:
> > > There is one important behaviour from Brian's original patch that yours
> > > doesn't replicate though-- when I change back to a regular theme from a
> > > large print theme, the icons don't get smaller again because the regular
> > > themes don't specify an icon size. Was this intentional?
> > >
> > > (Brian can explain how his patch worked, but I assume he set the sizes
> > > back to the default gtk sizes if they weren't explicitly specified in
> > > the rc file).
> > Are you really sure that this worked for Brian's original patch?
> > I believe I know the bug that is causing this, but it should affect
> > Brian's original patch as well.
> > (The bug is that when you reparse RC files, previously set settings
> > don't get cleared)
> Yes I'm fairly confident that this did work with my patch.
> I addressed this by adding two new values to the _IconSize structure in
> gtkiconfactory.c which kept track of the theme height/width. When the
> theme changed, the values for the theme height/width would be set to -1.
> This was done by calling _gtk_reset_icon_theme at the beginning of the
> gtk_rc_settings_changed function (called whenever gtk-theme-name or
> gtk-key-theme-name was modified).
Ah, OK, so you worked around it that way. It's not really correct though -
RC files dont' have to be loaded or reloaded through the icon theme
setting, and it leaves other settings broken the same way.
Filed the real problem as http://bugzilla.gnome.org/show_bug.cgi?id=94610.
] [Thread Prev