Patch for strange OptionMenu look



Hello,

I submitted this patch for #72695 on Bugzilla.

Comments?

-- 
Ettore
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/gtk+/ChangeLog,v
retrieving revision 1.3338.2.15
diff -u -u -r1.3338.2.15 ChangeLog
--- ChangeLog	29 Apr 2002 03:02:54 -0000	1.3338.2.15
+++ ChangeLog	30 Apr 2002 21:49:37 -0000
@@ -1,3 +1,10 @@
+2002-04-30  Ettore Perazzoli  <ettore ximian com>
+
+	* gtk/gtkmenu.c (gtk_menu_paint): If the menu is scrolled down or
+	up, and some of the widget area is empty, don't fill it in with
+	GTK_SHADOW_IN rectangles that make it looks strange.  Fixes
+	#72695.
+
 Sun Apr 28 22:43:55 2002  Jonathan Blandford  <jrb gnome org>
 
 	* gtk/gtktreemodelsort.c (gtk_tree_model_sort_set_sort_func): Fix
Index: gtk/gtkmenu.c
===================================================================
RCS file: /cvs/gnome/gtk+/gtk/gtkmenu.c,v
retrieving revision 1.97
diff -u -u -r1.97 gtkmenu.c
--- gtk/gtkmenu.c	26 Mar 2002 19:59:34 -0000	1.97
+++ gtk/gtkmenu.c	30 Apr 2002 21:49:38 -0000
@@ -1667,35 +1667,6 @@
 			   MENU_SCROLL_ARROW_HEIGHT - 2 * border_y - 2);
 	}
     }
-  else if (event->window == menu->view_window)
-    {
-      gint menu_height;
-      gint top_pos;
-      
-      if (menu->scroll_offset < 0)
-	gtk_paint_box (widget->style,
-		       menu->view_window,
-		       GTK_STATE_ACTIVE,
-		       GTK_SHADOW_IN,
-		       NULL, widget, "menu",
-		       0, 0,
-		       -1,
-		       -menu->scroll_offset);
-
-      menu_height = widget->requisition.height - 2*border_y;
-      top_pos = height - 2*border_y - (menu->upper_arrow_visible ? MENU_SCROLL_ARROW_HEIGHT : 0);
-
-      if (menu_height - menu->scroll_offset < top_pos)
-	gtk_paint_box (widget->style,
-		       menu->view_window,
-		       GTK_STATE_ACTIVE,
-		       GTK_SHADOW_IN,
-		       NULL, widget, "menu",
-		       0,
-		       menu_height - menu->scroll_offset,
-		       -1,
-		       top_pos - (menu_height - menu->scroll_offset));
-    }
 }
 
 static gboolean


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]