Re: patch for GtkDialog

[Havoc Pennington <hp redhat com>]

Havoc Pennington <hp redhat com> writes: 
> My opinion is that in practice, if you make this change then NO dialog
> will have Escape, even those that _do_ have cancel buttons. I don't
> think it's realistic to expect people to special-case dialogs with
> cancel vs. non-cancel. So in making a decision we may want to keep
> that in mind. Adding an Escape shortcut manually would be decidedly
> nontrivial with current API.

Clever idea: have the close window shortcut only apply if the dialog
has a button with GTK_RESPONSE_CANCEL.  (i.e. return FALSE from the
keybinding handler. Ugh, once again we should have made all keybinding
signals return boolean...)

Havoc