Re: -D_REENTRANT

[Sven Neumann <sven gimp org>]

Hi,

the patch I posted for Pango has a weird side-effect (all fonts
disappear). Of course mini-xft also has to be compiled -D_REENTRANT
since it uses errno. So here's a revised patch. If you agree I'll
commit this and the GTK+ change (with GTK_PIXBUF changed to 
GDK_PIXBUF).


Salut, Sven


Index: configure.in
===================================================================
RCS file: /cvs/gnome/pango/configure.in,v
retrieving revision 1.105
diff -u -p -r1.105 configure.in
--- configure.in        7 Mar 2002 19:45:48 -0000       1.105
+++ configure.in        14 Mar 2002 17:26:01 -0000
@@ -248,6 +248,8 @@ AM_PATH_GLIB_2_0($GLIB_REQUIRED_VERSION,
 *** Glib is always available from ftp://ftp.gtk.org/.]),
   gobject gmodule)
 
+GLIB_CFLAGS=`$PKG_CONFIG --cflags gthread-2.0`
+
 CFLAGS="$CFLAGS $GLIB_CFLAGS"
 
 AC_SUBST(GLIB_LIBS)
Index: pango/mini-xft/Makefile.am
===================================================================
RCS file: /cvs/gnome/pango/pango/mini-xft/Makefile.am,v
retrieving revision 1.1
diff -u -p -r1.1 Makefile.am
--- pango/mini-xft/Makefile.am  18 Nov 2001 16:06:02 -0000      1.1
+++ pango/mini-xft/Makefile.am  14 Mar 2002 17:26:01 -0000
@@ -4,6 +4,7 @@ INCLUDES =                                      \
        -DSYSCONFDIR=\"$(sysconfdir)\"          \
        -DLIBDIR=\"$(libdir)\"                  \
        $(FREETYPE_CFLAGS)                      \
+       $(GLIB_CFLAGS)                          \
        -I$(top_srcdir)
 
 LDADDS = @STRIP_BEGIN@                 \



Owen Taylor <otaylor redhat com> writes:

> > -GTK_DEP_CFLAGS="`$PKG_CONFIG --cflags  $GTK_PIXBUF_PACKAGES $GDK_PACKAGES $GTK_PACKAGES` $GDK_PIXBUF_EXTRA_CFLAGS $GDK_EXTRA_CFLAGS $GTK_EXTRA_CFLAGS"
> > +GTK_DEP_CFLAGS="`$PKG_CONFIG --cflags  $GTK_PIXBUF_PACKAGES $GDK_PACKAGES $GTK_PACKAGES gthread-2.0` $GDK_PIXBUF_EXTRA_CFLAGS $GDK_EXTRA_CFLAGS $GTK_EXTRA_CFLAGS"
>                                            ^^^^
> 
> Not a new problem with your patch, but definitely needs fixing.
> 
> Regards,
>                                         Owen