Re: [patch] gdk-pixbuf loaders crash on CMYK JPEGs

[Owen Taylor <otaylor redhat com>]

Michael Natterer <mitch gimp org> writes:

> Hi all,
> 
> currently io-jpeg.c simply crashes on CMYK JPEGs (or any JPEG with
> n_components != 1 or 3). The attached patch does the following:
> 
> - removes GREY->RGB conversion routine
> - uses the libjpeg built-in ability to promote everything to either
>   RGB or CMYK
> - adds CMYK->RGB conversion.
> - refuses to load files with unknown colorspace.
> 
> I guess it should be comitted to both branches.
> 
> OK to commit or is it too much of a change and should go to
> Bugzilla first?

Please see:

 http://bugzilla.gnome.org/show_bug.cgi?id=61211

If we need to make a fix in stable, I'd much rather either use:

 - The smallest possible fix (just error on unknown colorspaces)

Or:

 - The code we are already using in HEAD

Regards,
                                        Owen