Re: bugs for GTK+-2.0.6 release

[Owen Taylor <otaylor redhat com>]

"Shivram U" <shivaram upadhyayula wipro com> writes:

> Hi Owen,
> 
> > I'm planning to start work on a GTK+-2.0.6 release tomorrow.
> > My current plan is to release *exactly* what is in CVS now:
> > I think we need a new release to fix bug #85976
> > (menu keynav problems with insensitive menu items), and to
> > get out some tree view fixes that Kris and Jonathan have
> > done; but I don't really have time to go through bugzilla.
> >
> > I'd like to ask people if they know of any other bugs that are:
> >
> >  - Urgent (crashes, bad misbehavior)
> >  - Tracked down to something specific
> >  - We have a patch, or it should be easy to make a patch.
> >
>    http://bugzilla.gnome.org/show_bug.cgi?id=75597 There is a patch
> available. If it requires any modifications, i'll make them.

I think this is most suitable for only going in HEAD since it just
adds warnings for application errors and doesn't actually fix any bugs
in GTK+.

Go ahead and commit to GTK+ HEAD, though I'd suggest, as an
editorial suggestion:

+  if (image->depth != v->depth)
+    {
+      g_warning ("%s: Depth of the Source image is %d where as "
+                 "the visual depth of the colormap passed is %d",
+                 G_STRLOC, image->depth, v->depth);
+      return;
+    } 

Would be better as

+      g_warning ("%s: The depth of the source image (%d) doesn't"
+                 "match the depth of the colormap passed in (%d)."),
+                 G_STRLOC, image->depth, v->depth);

Regards,
                                        Owen