Impact of fix for bug 50339 on keyboard accessibility of panel



The fix for bug 50339, setting a focus widget in a GtkWindow if it contains a 
focusable widget, has caused me a problem with keyboard access to the panel.

Is it the intention of this bug fix that a GtkWindow should never have focus if 
it contains a focusdable widget?

I need keyboard focus in the panel in order to access its context menu. I also 
need keyboard focus on the objects on the panel.

I had done this by regarding focus on the panel as the BasePWidget, which 
derives from GtkWindow, having focus.

Would the following change to gtkwindow.c be accepted?

Index: gtkwindow.c
===================================================================
RCS file: /cvs/gnome/gtk+/gtk/gtkwindow.c,v
retrieving revision 1.188
diff -u -p -r1.188 gtkwindow.c
--- gtkwindow.c	2002/01/30 23:35:08	1.188
+++ gtkwindow.c	2002/01/31 13:31:18
@@ -3039,7 +3039,7 @@ gtk_window_show (GtkWidget *widget)
   /* Try to make sure that we have some focused widget
    */
   if (!window->focus_widget)
-    gtk_window_move_focus (window, GTK_DIR_TAB_FORWARD);
+    GTK_WINDOW_GET_CLASS (window)->move_focus (window, GTK_DIR_TAB_FORWARD);
   
   if (window->modal)
     gtk_grab_add (widget);




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]