Re: Interface macro usage



On 8 Jan 2002, Mike Kestner wrote:

> On Tue, 2002-01-08 at 06:41, Tim Janik wrote:
> 
> > if you'd provide a patch (cvs diff -up) and post it here, that'd be
> > much apprechiated.
> 
> Attached. Let me know if you want me to commit.

thanks, looks good, please commit with aapropriate changelog entry.

> While I'm whining about stuff... I also tripped over this little gem:
> 
> typedef struct _GdkRectangle GtkAllocation;
> 
> Referencing incomplete, out of namespace types seems a bit off, and it
> forces me to parse both the gdk and gtk namespaces in one pass which is
> something I'd rather not do.  It's fairly gratuitous, but would it be
> okay to change this to:
> 
> typedef GdkRectangle GtkAllocation;

sure, that change is fine. just be aware that your parser isn't
really robust C then ;)

> 
> Mike
> 

---
ciaoTJ




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]