Re: AtkText caret_changed signal name

["Padraig O'Briain" <Padraig Obriain Sun COM>]

Jeff,

Thanks for you mail which I do not regard as "very minor".

I propose to change caret_changed to text_caret_moved and CARET_MOVED to 
TEXT_CARET_MOVED. This means that anyone who has defined a default signal 
handler for "text-caret_moved" signal will need to change their code.

The name of the signal, "text-caret-moved", which is used by the Gnopernicus 
developers, will remain unchanged.

Padraig

> Delivered-To: gtk-devel-list gnome org
> User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.7) Gecko/20011221
> X-Accept-Language: en-us
> MIME-Version: 1.0
> To: gtk-devel-list gnome org
> Subject: AtkText caret_changed signal name
> Content-Transfer-Encoding: 7bit
> X-BeenThere: gtk-devel-list gnome org
> X-Loop: gtk-devel-list gnome org
> X-Mailman-Version: 2.0.6
> List-Help: <mailto:gtk-devel-list-request gnome org?subject=help>
> List-Post: <mailto:gtk-devel-list gnome org>
> List-Subscribe: <http://mail.gnome.org/mailman/listinfo/gtk-devel-list>, 
<mailto:gtk-devel-list-request gnome org?subject=subscribe>
> List-Id: Development of GTK+ <gtk-devel-list.gnome.org>
> List-Unsubscribe: <http://mail.gnome.org/mailman/listinfo/gtk-devel-list>, 
<mailto:gtk-devel-list-request gnome org?subject=unsubscribe>
> List-Archive: <http://mail.gnome.org/archives/gtk-devel-list/>
> 
> Hi,
> 
> Just a very, very minor query. The naming of AtkText's caret_changed
> signal seems inconsistent with the naming of other signals.
> 
> In atktext.h the signal is declared as:
> 
>              void  (*caret_changed)  (AtkText *text, gint location);
> 
> and in the unnamed signal enum in atktext.c it is listed as:
> 
>             CARET_MOVED
> 
> and in the atk_text_base_init function it is named as:
> 
>             "text_caret_moved"
> 
> Wouldn't it be better if it was entirely 'moved' or 'changed'.
> PersonallyI like 'moved'.
> 
> Jeff.
> 
> 
> 
> 
> 
> 
> _______________________________________________
> gtk-devel-list mailing list
> gtk-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/gtk-devel-list