Re: gdkkeys-x11.c:842: warning: suggest parentheses
- From: Owen Taylor <otaylor redhat com>
- To: Sven Neumann <sven gimp org>
- Cc: gtk-devel-list gnome org
- Subject: Re: gdkkeys-x11.c:842: warning: suggest parentheses
- Date: Mon, 25 Feb 2002 12:49:09 -0500 (EST)
Sven Neumann <sven gimp org> writes:
> my compiler suggests the following change:
>
> gdkkeys-x11.c: In function `gdk_keymap_translate_keyboard_state':
> gdkkeys-x11.c:842: warning: suggest parentheses around comparison in operand of &
>
> the offending line looks like this:
>
> if (tmp_keyval == GDK_Tab && (tmp_modifiers & GDK_SHIFT_MASK == 0))
>
> I don't think parentheses around the comparison would make this behave
> as intended
That's just a polite way for GCC to say "Owen screwed up" :-).
Fixed, thanks,
Owen
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]