broken accelerator changes

[Tim Janik <timj gtk org>]

hi.

the following change broke accelerator installation (again):

Sun Feb 17 21:30:49 2002  Owen Taylor  <otaylor redhat com>

        * gtk/gtkmenu.c (gtk_menu_class_init): Fix setting default.

@@ -259,7 +259,7 @@ gtk_menu_class_init (GtkMenuClass *class
   gtk_settings_install_property (g_param_spec_boolean ("gtk-can-change-accels",
                                                       _("Can change accelerators"),
                                                       _("Whether menu accelerators can be changed by pressing a key over the menu item."),
-                                                      TRUE,
+                                                      FALSE,
                                                       G_PARAM_READWRITE));
 }

which i had recently fixed:

Wed Feb 13 13:26:39 2002  Tim Janik  <timj gtk org>

        * gtk/gtkmenu.c: fix figuring accel path and changing behaviour.

by setting the default to TRUE.

i can only reiterate the corner aspects of why it is a bad
idea to break this:
- for non-US users changing accelerators is an essential requirement
  to use applications as their keyboard layouts are different and
  application default accelerator setups are often unusable.
- the majority of gtk+1.2 bug reports about accelerators have been
  taken care of with the new code, we fixed conflict resolution etc.
  there's no need to break runtime changes of them as some bugzilla
  comments suggest, they were based on misunderstandings about the
  bugs involved.
- gtk has offered runtime changes of accelerators since 1.0, and there
  has been some arguing on gtk-devel on whether to change the default
  behaviour or not. but since we have policy to not change behaviour
  without consensus, the outcome of the related email and irc discussions
  on this were to not alter behaviour for 2.0.
- the "users might be confused by being able to change their accelerators"
  argument is a weak one. first, they can easily remove their accidental
  settings by pressing another key or backspace/delete which is intuitive
  enough to be figured by people who know what backspace/delete are about.
  second, users who already know gtk+ would be just as confused about not
  being able to change accels anymore. and third, this argument has to be
  considered in relation to non-US users not being able to facilitaty
  accelerators at all, mild confusion about new users is the lesser evil here.
- at last, the "windows doesn't do this" is a non-argument, developers who're
  out aiming at a clone of some MS windows version are better off joining
  the KDE project, microsoft is not the end-and-all of it in all its
  usability decisions.

---
ciaoTJ