Re: AC_DEFINE statements in glib-gettext.m4

[James Henstridge <james daa com au>]

Owen Taylor wrote:

> James Henstridge <james daa com au> writes:
>
> > It would be quite useful to add the third argument (the description)
> > to the two AC_DEFINE() calls in glib-gettext.m4.  This would mean that
> > if someone adds a call to AM_GLIB_GNU_GETTEXT to their app, they don't
> > have to remember to put anything extra in their acconfig.h file (in
> > fact, the acconfig.h file is considered a deprecated for newer
> > autoconf versions).
> >
> > This change would not affect any existing configure scripts (it is not
> > an error to list the config var in both acconfig.h and pass the third
> > arg to AC_DEFINE).
> >
> > Any objections to adding the descriptions?
>
> Is the 3rd argument allowed with autoconf-2.13. While we
yes it does work with 2.13.  From the 2.13 info pages:
- Macro: AC_DEFINE (VARIABLE [, VALUE [, DESCRIPTION]])
    Define C preprocessor variable VARIABLE.  If VALUE is given, set
    VARIABLE to that value (verbatim), otherwise set it to 1.  VALUE ...

(I am not even sure if m4 macros can check if they have been passed too 
many arguments anyway).

> distribute tarballs build with 2.5x these days some people
> (Tim at least) are still using 2.13, and if we decide to
> break that, we need to add the appropriate AC_PREREQ().
This wouldn't require an AC_PREREQ.

James.

--
Email: james daa com au
WWW:   http://www.daa.com.au/~james/