Re: gtk_accelerator_set_default_mod_mask ()

[Jody Goldberg <jody gnome org>]

On Sat, Feb 02, 2002 at 10:14:29PM -0500, Owen Taylor wrote:
> 
> Would it make sense to add:
> 
>  mask |= GTK_MOD1_MASK | GDK_SHIFT_MASK | GDK_CONTROL_MASK
> 
> to this function... that is, not allow setting a mask more restrictive
> than the default mask?

I'd favour a stronger contract.
g_return_if_fail ((new_mask & GTK_MOD1_MASK | GDK_SHIFT_MASK | GDK_CONTROL_MASK) != (GTK_MOD1_MASK | GDK_SHIFT_MASK | GDK_CONTROL_MASK));

Since gtk+ breaks when one of these is removed then it is broken to
remove them.   The developer should be notified in no uncertain
terms that it is broken.  IMHO, silently succeeding is not enough
warning.