Re: gtk_type_init() with no X connection [was: Re: horrible things]

[Owen Taylor <otaylor redhat com>]

jacob berkman <jacob ximian com> writes:

> On Sun, 2001-10-28 at 09:32, Owen Taylor wrote:
> > 
> > jacob berkman <jacob ximian com> writes:
> > 
> > > On Wed, 2001-10-24 at 21:15, Owen Taylor wrote:
> > > > 
> > > > > > jacob berkman <jacob ximian com> writes:
> > > > > > 
> > > > > > > this patch allows the gtk docs to build w/o an X connection.
> > > > 
> > > > Looks like its definitely heading in the right direction.
> > 
> > Returning NULL here is not a good at all since it will just
> > segfault programs. Why don't you:
> > 
> >  - Remove the cmap and visual fields from GtkPreviewInfo
> >  - Add a quick entry to Changes-2.0.txt mentioning that
> >  - Make gtk_preview_get_cmap/visual return 
> >    gdk_rgb_get_colormap(), gdk_rgb_get_visual().
> >  - Deprecate gtk_preview_get_cmap/visual.
> 
> because i didn't know that removing the fields from GtkPreviewInfo was
> allowed :)  fixed in new patch
> 
> > This doesn't work, does it? gtk_color_selection_set_change_palette_hook()
> > could be (and probably will be) called before the first colorsell
> > is realized.
> 
> correct - i didn't understand the code enough.  fixed in new patch.

Looks good, please commit.

Thanks,
                                        Owen