Re: static correctness

[Tim Janik <timj gtk org>]

On Sat, 27 Oct 2001, Hans Breuer wrote:

> At 20:11 26.10.01 +0200, Tim Janik wrote:
> >> [...]
> >
> >postiong the patch here when asking for aproval won't hurt
> >though and might speed up matters.
> >
> Part Two (Gdk)
> 
> 	* gdk/gdk.c gdk/gdkevents.c
> 	  gdk/win32/gdkcolor-win32.c gdk/win32/gdkdnd-win32.c
> 	  gdk/win32/gdkdrawable-win32.c gdk/win32/gdkevents-win32.c
> 	  gdk/win32/gdkfont-win32.c gdk/win32/gdkgc-win32.c
> 	  gdk/win32/gdkim-win32.c gdk/win32/gdkmain-win32.c
> 	  gdk/win32/gdkpixmap-win32.c gdk/win32/gdkpixmap-win32.h
> 	  gdk/win32/gdkprivate-win32.h gdk/win32/gdkproperty-win32.c
> 	  gdk/win32/gdkselection-win32.c gdk/win32/gdkwin32.h
> 	  gdk/win32/gdkwindow-win32.c gdk/win32/gdkwindow-win32.h
> 	  gdk/x11/gdkmain-x11.c gdk/x11/gdkpixmap-x11.c
> 	  gdk/x11/gdkpixmap-x11.h gdk/x11/gdkwindow-x11.c
> 	  gdk/x11/gdkwindow-x11.h :
> 	static correct-ness, underscore prefixing of library internal functions

as "library internal" functions here, you also took the type id retrival
functions for the implementation types.
pondering this a bit, i think that's ok. normal apps shouldn't
ever need to derive from these or use their type ids. and type
scanners like glade or somesuch don't need them either.

owen, am i right, in that normal apps also won't access the GDK_*_IMPL_*
macros, which use the _gdk_*_impl_get_type() functions?

> Only in my-gtk/gtk+/gdk/win32/rc: gdk.rc
> diff --ignore-space-change --exclude-from=c:\util\tool\diff.ign -u -r
> from-cvs/gtk+/gdk/x11/gdkmain-x11.c my-gtk/gtk+/gdk/x11/gdkmain-x11.c
> --- from-cvs/gtk+/gdk/x11/gdkmain-x11.c	Sat Oct 27 01:40:00 2001
> +++ my-gtk/gtk+/gdk/x11/gdkmain-x11.c	Wed Oct 24 20:28:40 2001
> @@ -115,7 +115,7 @@
>  {
>    XKeyboardState keyboard_state;
>    XClassHint *class_hint;
> -  gulong pid;
> +  guint pid;

the correct type here is indeed gulong (arg for XChangeProperty).

---
ciaoTJ