Re: #59579: patch

["Padraig O'Briain" <Padraig Obriain sun com>]

I am not happy with this change. It changes the behavior of clicking on a menu 
item in the menu bar. Now a menu item in the submenu is selected whereas 
previously one was not.

It will also cut across what we have trying to do for accessibility, i.e. having 
F10 leave the current menu as the menubar rather than the submenu of the first 
menu item.

Padraig

> 
> Hi,
> 
> Here's a patch which fixes #59579 (Scroll menus should remember last
> position). ChangeLog:
> 
> Fri Oct  5 18:33:43 2001  Kristian Rietveld  <kristian planet nl>
> 
>         * gtk/gtkmenu.c (gtk_menu_popup): add a call to
>         gtk_menu_shell_select_item() to activate the last activated item.
> 
>         Fixes bug #59579
> 
> 
> Actual patch has been appended.
> 
> Ok to commit?
> 
> regards,
> 
> 
> 	Kris
> 
> 
> Index: gtkmenu.c
> ===================================================================
> RCS file: /cvs/gnome/gtk+/gtk/gtkmenu.c,v
> retrieving revision 1.73
> diff -u -r1.73 gtkmenu.c
> --- gtkmenu.c	2001/09/22 14:55:02	1.73
> +++ gtkmenu.c	2001/10/05 15:27:39
> @@ -629,6 +629,9 @@
>    gtk_widget_show (GTK_WIDGET (menu));
>    gtk_widget_show (menu->toplevel);
> 
> +  gtk_menu_shell_select_item (GTK_MENU_SHELL (menu),
> +			      gtk_menu_get_active (GTK_MENU (menu)));
> +
>    if (current_event)
>      {
>        /* Also, if we're popping up from a key event, select the first
> 
> 
> _______________________________________________
> gtk-devel-list mailing list
> gtk-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/gtk-devel-list