Re: [PATCH] make make dist work without making first



On Tue, 2001-10-02 at 17:48, Owen Taylor wrote:
> 
> jacob berkman <jacob ximian com> writes:
> 
> > this patch was required for me to be able to make dist without distcheck
> > or building initially.
> 
> Hmm, in general, I'd consider this to be a rather unsupported usage,
> just because it is hard to keep a check on, but I guess we can 
> try to apply some patches and see if we can do it.

well considering i'll be building hourly / nightly gnome 2 snapshots,
i'll know pretty quickly after it breaks.

right now i just ran into the fact that the doc generation code needs an
X connection - looking forward to fixing this (i know this kind of thing
thrills msw).

> 
> > Index: gobject/Makefile.am
> > ===================================================================
> > RCS file: /cvs/gnome/glib/gobject/Makefile.am,v
> > retrieving revision 1.40
> > diff -u -r1.40 Makefile.am
> > --- gobject/Makefile.am	2001/09/25 06:03:22	1.40
> > +++ gobject/Makefile.am	2001/10/01 22:28:54
> > @@ -14,6 +14,9 @@
> >  
> >  libglib = $(top_builddir)/glib/libglib-1.3.la
> >  
> > +$(libglib):
> > +	$(MAKE) -C $(top_builddir)/glib
> 
> This is fairly evil because there is no guarantee that the $(libglib)
> is up-to-date, just that it exists.

i figured you would have a better way of doing it, which why i sent the
patch in; thanks.

> >  
> > +dist-hook-local: all-local
> >  
> >  ####################################
> >  # Everything below here is generic #
> 
> I assume that this is meant to be _below_ 

i wasn't sure - but had guessed so.  will move it and fix like you
suggest.



jacob
-- 
"It drains me, and it shakes me, and hurts like hell everytime I play
it, looking out at thousands of people cheering and smiling, oblivious
to the tragedy of it's meaning, like when you're going to have your
dog put down and it's wagging it's tail on the way there." - Thom Yorke




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]