Re: [PATCH] Bug #65540, with merge from gdk-pixbuf stable branch



Federico Mena Quintero <federico ximian com> writes:

> Hello,
> 
> I am doing some merging of gdk-pixbuf patches across the stable and GTK+
> 1.3 branches.  So I took the (newer) io-bmp from 1.3, reworked it for
> the stable branch, and also fixed Ximian bug #12125.
> 
> The bug fix is essentially adding support for BI_BITFIELDS coding to the
> BMP loader --- Windows boxes with 5-6-5 16bpp displays seem to use this
> coding when creating BMPs.
> 
> I have logged bug #65540 with the attached patch.  Is it OK to commit?

If you think it's OK, go ahead; it's not like anybody here is
going to have the knowledge to do a detailed code review of this
change.

(Once we get around to auditing the loaders, then any change of this
 size is going to need auditing as well, of course.)

Regards,
                                        Owen





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]