Re: the separator in GtkDialog

[Havoc Pennington <hp redhat com>]

jacob berkman <jacob ximian com> writes:
> I would like to start of by making a plea here for the removal of the
> separator in GtkDialog.  i think it is a dumb waste of space, and
> haven't seen any cases where it's useful (in fact, until recently i ran
> a patched gnome with the separator removed).
> 
> that aside, it is pretty nasty that you can turn the separator on / off
> in message dialogs.  either gtk should always put the separator there,
> or it never should.  otherwise, we get some annoying inconsistency
> (besides having to pass GTK_DIALOG_NO_SEPARATOR to all of the message
> dialogs).
> 
> i don't know if this has been beaten to death, but it is something that
> should probably get a little bit of attention before 2.0.
> 

The thought was this: if you have a dialog containing a frame, then
you don't want the separator also, but if you have a dialog with no
frame, you probably want a separator. So that's why it's
programmer-configurable instead of a theme thing.

For message dialogs, I suppose the current idea is that you should not
be turning it off. We should probably enforce that by ignoring the
flag on message dilaog creation, Owen says he agrees. Though
set_has_separator() would still work.

As to whether it should be an option at all or ever be on at all, I
guess it's kind of a style guide or graphic design issue, I am fairly
unopinionated on this and not sure how to go about deciding.

Havoc