Re: Impact of change to gcompletion.h on building gtk+ on Solaris

[Owen Taylor <otaylor redhat com>]

"Padraig O'Briain" <Padraig Obriain Sun COM> writes:

> This patch fixes my problem. May I commit?

Go ahead.

>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <string.h>
>  #include <gmodule.h>
> +#ifdef G_OS_UNIX
> +#include <unistd.h>
> +#endif
>  #include "gtkdnd.h"
>  #include "gtkcompat.h"
>  #include "gtkmain.h"

Though it's slightly better to keep all the system headers together and before
other headers, so I'd do:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#ifdef G_OS_UNIX
#include <unistd.h>
#endif

#include <gmodule.h>

#include "gtkdnd.h"
#include "gtkcompat.h"
#include "gtkmain.h"

Regards,
                                        Owen