Re: #50215 - g_param_spec_string_c is a very cryptic function name



On 28 Mar 2001, Owen Taylor wrote:

> Tim Janik <timj gtk org> writes:
> 
> > On 26 Mar 2001, Owen Taylor wrote:
> > 
> > > 
> > > I see that g_param_spec_string_c has been renamed to g_param_spec_stringc.
> > > 
> > > I don't think this makes it much clearer ;-)
> > > 
> > > 
> > > What the function appears to do is to create a string parameter spec
> > > with a validation rule equivalent to that for C indentifiers.
> > > 
> > > But that has nothing to do with C strings are, and the single letter
> > > 'c' is generally rather confusing without further context.
> > > 
> > > How about g_param_spec_identifier?
> > 
> > shouldn't it say that it's a C identifier? i.e. through
> > g_param_spec_cidentifier() ?
> 
> I think g_signal_newc has filled the niche for "random additions of 
> the letter c".
> 
> I think plain g_param_spec_identifier() is fine. It's not like we are
> goign to have g_param_spec_fortranidentifier any time soon.

ok, but that name might be confusing since we have GTK_TYPE_IDENTIFIER,
derived from G_TYPE_STRING, so theoretically we're wasting a namespace
there.

> 
>                                         Owen
> 

---
ciaoTJ





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]