Re: volunteer needed: event return values



On 22 Mar 2001, Havoc Pennington wrote:

> 
> Hi,
> 
> I went through Seth's patch and mostly just applied it, I fixed a few
> formatting issues. Looks pretty good. I'll commit in the morning if no
> objections, so Tim can go ahead and try out the accumulator stuff. We
> need to get that change in CVS so we can see what breaks and get some
> testing.
> 
> Seth, thanks for the patch!

yeah, thanks also.
just a minor comment, for changes like this it'd be good if people would
use the -p option to diff (like alex does) to know what function is actually
affected by a small context-less snippet like:

     default:
       break;
     }
   }
  
-  return FALSE;
+  return TRUE;
 }

> 
> Havoc
> 

---
ciaoTJ





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]