Alright -- my updated gboolean patch is ready and uploaded to: http://bugzilla.gnome.org/show_bug.cgi?id=51041 the patch itself lives at: http://bugzilla.gnome.org/showattachment.cgi?attach_id=407 Summary: I fixed it up, and it should be fine to apply, but: * I can't get GTK to build anyway, so the patch might break something * There's a few other functions that might need to be changed (see Questions at bottom) -------------- The old one applied mostly fine; the only problems were: (1) Some functions no longer existed: ..._expose ..._focus_{in,out} (misc. others) (2) some indentation corrections associated to (1) thus didn't work, but that's not really in the scope of this patch. (3) misc. changes confused patch (4) Some instances had already been changed to gboolean Thus spake Nils Barth: > Thus spake Owen Taylor: > > While going through old back patches, I noticed that your > > gint => gboolean patch was never applied. > > > > (http://bugzilla.gnome.org/show_bug.cgi?id=51041) > > > > It looks mostly correct, but there is a problem with quite > > a few occurrences of: > > > > - guint show_text : 1; > > - guint activity_mode : 1; > > + gboolean show_text : 1; > > + gboolean activity_mode : 1; > > > > Which is incorrect, since to hold the values FALSE and TRUE, > > a bitfield must be unsigned, and gboolean is signed. > right -- this was brought up... These have now been reverted. > also, I missed a few and someone else pointed them out (in a later > thread...) Specifically, Oskar Liljeblad, 2000-09-03 Message-ID: <20000903175309 A28271 oskar> mentioned some that I missed, which have been fixed, EXCEPT: (1) The events in gtkwidget.h:/* events */ (2) The events in gtkrange.h:'struct _GtkRangeClass', namely timer, trough_keys, trough_click These appear to be gbooleans -- is there any reason why they are gints, or should they be changed? -- -nils Public key: http://www.nbarth.net/~nbarth/pub-key.txt
Attachment:
pgp5y9O8lJGdP.pgp
Description: PGP signature