Re: Updated stock toolbars
- From: Owen Taylor <otaylor redhat com>
- To: gtk-devel-list gnome org
- Cc: alla lysator liu se
- Subject: Re: Updated stock toolbars
- Date: 14 Mar 2001 16:45:27 -0500
Alexander Larsson <alla lysator liu se> writes:
> I've updated my toolbar patch to use the icon size enum.
>
> Do we want all of append/prepend/insert, or should I keep just insert?
OK, this looks good to commit with the comments:
* Just keep insert, I think the win in keeping the API size down is
definitely worth the need to learn the convention of -1 to mean
"end" which is used consistently throughout GTK+.
> +void
> +gtk_toolbar_set_stock_size (GtkToolbar *toolbar,
> + GtkIconSize icon_size)
* I think this is better as set_icon_size().
* You need doc comments for set_icon_size() and insert_stock()
Thanks,
Owen
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]