Re: TreeView search dialog -- new patch

[Jonathan Blandford <jrb redhat com>]

Kristian Rietveld <kristian planet nl> writes:

> Hi,
> 
> This is a new patch which adds the interactive search code to the
> TreeView. New is the 'configurable search dialog position function' ;)
> (featuring long and ugly prototypes ...), besides that, nothing has been
> changed. I think this will be my latest patch for a long time, because I'm
> leaving Saturday for three weeks (holiday ;).
> 
> As always, suggestions/comments/etc are welcome.

Looks extremely cool.  It basically works, though there are a few minor
bugs.  To be specific:

 * You should popdown on focus out.
 * The first letter doesn't seem to work. (ie, typing N doesn't do
   anything on testtreefocus, for example.)
 * It seems to interfere with keybindings.  For example, C-n doesn't go
   to the next line, it starts typing n.
 * I think activating the entry should move the cursor to the current
   highlighted location.

But these can all be fixed.  It really helps the usability of the tree
too.

Thanks,
-Jonathan