Re: GList insert_before variants

[Owen Taylor <otaylor redhat com>]

Tim Janik <timj gtk org> writes:

> posting for review, upcomming patch for glib to implement
> gslist/glist insert_before variants:
> 
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/glib/ChangeLog,v
> retrieving revision 1.737
> diff -u -u -r1.737 ChangeLog
> --- ChangeLog	2001/06/28 17:05:10	1.737
> +++ ChangeLog	2001/06/30 21:13:20
> @@ -1,3 +1,10 @@
> +Sat Jun 30 23:14:32 2001  Tim Janik  <timj gtk org>
> +
> +	* glib/glist.[hc]: added g_list_insert_before().
> +
> +	* glib/gslist.c (g_slist_insert_before): provide an implementation,
> +	prototype was already present...
> +

Looks fine to me. Only thing I'd say is that docs would
be good, especially to document the behavior of
g_list_insert_before (slist, NULL, data).

Regards,
                                        Owen