Re: [PATCH] make default string for sample text of font selectorlocalizable



>> I think it would be nice to make the string "abcdefghijk ABCDEFGHIJK"  used
>> as default string in gtk font selection widget internationalizable. Here is a
>> patch for it.
>> 
>> I had to remove macro PREVIEW_TEXT (and turn it into variable), since if it's
>> defined as
>> #define PREVIEW_TEXT _("abcdefghijk ABCDEFGHIJK")

on 2/27/01 8:09 AM, Mathieu Lacage at mathieu gnu org wrote:

> Perhaps the correct way to do it is:
> #define PREVIEW_TEXT N_("abcdefghijk ABCDEFGHIJK")
> which will mark the string as translatable and will put it in the po
> files.
> Also, in the code using the  PREVIEW_TEXT macro, you should do:
> _(PREVIEW_TEXT)

Mathieu's suggestion won't work. We had a lot of code like this in Nautlius.
The gettext code doesn't look at macro expansion lines. So you need to
change it to not be a macro as Vlad's patch does. (If you look in Nautilus
sources you'll find examples of macros which we had to change so that the
_() bit is not in the macro.)

    -- Darin





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]