expose_event return value
- From: Alex Larsson <alexl redhat com>
- To: <gtk-devel-list gnome org>
- Subject: expose_event return value
- Date: Sun, 2 Dec 2001 22:57:50 -0500 (EST)
A few of the widgets in gtk+ return TRUE in their expose_event handler.
This makes it impossible to connect_after to the signal and draw stuff.
Here is a patch that changes all the places i found.
Ok to check in?
/ Alex
Index: gtkaccellabel.c
===================================================================
RCS file: /cvs/gnome/gtk+/gtk/gtkaccellabel.c,v
retrieving revision 1.36
diff -u -p -r1.36 gtkaccellabel.c
--- gtkaccellabel.c 2001/11/29 01:15:52 1.36
+++ gtkaccellabel.c 2001/12/03 03:53:50
@@ -345,7 +345,7 @@ gtk_accel_label_expose_event (GtkWidget
}
}
- return TRUE;
+ return FALSE;
}
static void
Index: gtkarrow.c
===================================================================
RCS file: /cvs/gnome/gtk+/gtk/gtkarrow.c,v
retrieving revision 1.17
diff -u -p -r1.17 gtkarrow.c
--- gtkarrow.c 2001/08/11 20:27:35 1.17
+++ gtkarrow.c 2001/12/03 03:53:50
@@ -271,5 +271,5 @@ gtk_arrow_expose (GtkWidget *widget
x, y, extent, extent);
}
- return TRUE;
+ return FALSE;
}
Index: gtkcolorsel.c
===================================================================
RCS file: /cvs/gnome/gtk+/gtk/gtkcolorsel.c,v
retrieving revision 1.81
diff -u -p -r1.81 gtkcolorsel.c
--- gtkcolorsel.c 2001/11/17 23:28:49 1.81
+++ gtkcolorsel.c 2001/12/03 03:53:50
@@ -478,21 +478,23 @@ color_sample_draw_samples (GtkColorSelec
color_sample_draw_sample (colorsel, 1);
}
-static void
+static gboolean
color_old_sample_expose (GtkWidget *da,
GdkEventExpose *event,
GtkColorSelection *colorsel)
{
color_sample_draw_sample (colorsel, 0);
+ return FALSE;
}
-static void
+static gboolean
color_cur_sample_expose (GtkWidget *da,
GdkEventExpose *event,
GtkColorSelection *colorsel)
{
color_sample_draw_sample (colorsel, 1);
+ return FALSE;
}
static void
@@ -813,15 +815,17 @@ palette_set_color (GtkWidget *dr
gtk_object_set_data (GTK_OBJECT (drawing_area), "color_val", new_color);
}
-static void
+static gboolean
palette_expose (GtkWidget *drawing_area,
GdkEventExpose *event,
gpointer data)
{
if (drawing_area->window == NULL)
- return;
+ return FALSE;
palette_paint (drawing_area, &(event->area), data);
+
+ return FALSE;
}
static void
Index: gtkcontainer.c
===================================================================
RCS file: /cvs/gnome/gtk+/gtk/gtkcontainer.c,v
retrieving revision 1.97
diff -u -p -r1.97 gtkcontainer.c
--- gtkcontainer.c 2001/11/20 22:40:39 1.97
+++ gtkcontainer.c 2001/12/03 03:53:51
@@ -2165,7 +2165,7 @@ gtk_container_expose (GtkWidget *wi
&data);
}
- return TRUE;
+ return FALSE;
}
static void
Index: gtklabel.c
===================================================================
RCS file: /cvs/gnome/gtk+/gtk/gtklabel.c,v
retrieving revision 1.112
diff -u -p -r1.112 gtklabel.c
--- gtklabel.c 2001/11/19 19:20:21 1.112
+++ gtklabel.c 2001/12/03 03:53:52
@@ -1765,7 +1765,7 @@ gtk_label_expose (GtkWidget *widget
gtk_label_draw_cursor (label, x, y);
}
- return TRUE;
+ return FALSE;
}
static void
Index: gtktextview.c
===================================================================
RCS file: /cvs/gnome/gtk+/gtk/gtktextview.c,v
retrieving revision 1.147
diff -u -p -r1.147 gtktextview.c
--- gtktextview.c 2001/11/28 20:42:15 1.147
+++ gtktextview.c 2001/12/03 03:53:54
@@ -3770,7 +3770,7 @@ gtk_text_view_expose_event (GtkWidget *w
if (event->window == widget->window)
gtk_text_view_draw_focus (widget);
- return TRUE;
+ return FALSE;
}
static void
Index: gtktogglebutton.c
===================================================================
RCS file: /cvs/gnome/gtk+/gtk/gtktogglebutton.c,v
retrieving revision 1.43
diff -u -p -r1.43 gtktogglebutton.c
--- gtktogglebutton.c 2001/11/17 23:28:51 1.43
+++ gtktogglebutton.c 2001/12/03 03:53:54
@@ -480,7 +480,7 @@ gtk_toggle_button_expose (GtkWidget
gtk_container_propagate_expose (GTK_CONTAINER (widget), child, event);
}
- return TRUE;
+ return FALSE;
}
static void
Index: gtktreeview.c
===================================================================
RCS file: /cvs/gnome/gtk+/gtk/gtktreeview.c,v
retrieving revision 1.175
diff -u -p -r1.175 gtktreeview.c
--- gtktreeview.c 2001/11/19 21:18:21 1.175
+++ gtktreeview.c 2001/12/03 03:53:56
@@ -2858,7 +2858,7 @@ gtk_tree_view_bin_expose (GtkWidget
if (drag_dest_path)
gtk_tree_path_free (drag_dest_path);
- return TRUE;
+ return FALSE;
}
static gboolean
Index: gtkwindow.c
===================================================================
RCS file: /cvs/gnome/gtk+/gtk/gtkwindow.c,v
retrieving revision 1.172
diff -u -p -r1.172 gtkwindow.c
--- gtkwindow.c 2001/11/28 23:41:09 1.172
+++ gtkwindow.c 2001/12/03 03:53:58
@@ -4669,7 +4669,7 @@ gtk_window_expose (GtkWidget *widge
if (GTK_WIDGET_CLASS (parent_class)->expose_event)
return GTK_WIDGET_CLASS (parent_class)->expose_event (widget, event);
- return TRUE;
+ return FALSE;
}
/**
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]