Re: gtkwindow changes
- From: Owen Taylor <otaylor redhat com>
- To: Tim Janik <timj gtk org>
- Cc: Havoc Pennington <hp redhat com>, Gtk+ Developers <gtk-devel-list gnome org>
- Subject: Re: gtkwindow changes
- Date: 17 Aug 2001 14:12:12 -0400
Tim Janik <timj gtk org> writes:
> On 17 Aug 2001, Havoc Pennington wrote:
>
> >
> > Hi,
> >
> > Tim, I'm not sure about adding this in gtk_window_move_resize():
> >
> > window->need_default_position = FALSE;
> >
> > it's sort of a bad hack. Can you explain what the loop is that you're
> > trying to fix? I think we can probably fix it more nicely.
>
> if you have an immeditely resizing container, your code to reset
> need_default_position in map() was never triggered, we'd get
> into endless recursion from move_resize.
> for a test, revert gtkwindow.c to before my commit and click
> on GLE's selector button, it'll just segfault on stack overflow
> from recursion in gtk_window_move_resize().
> (that's also why i added some comments about IMMEDIATE resize containers
> so we keep that in mind for future changes).
Hmm, was it even intended that you could set a toplevel window to
RESIZE_IMMEDIATE? The potential for causing yourself serious problem
with this is quite high.
Is there a good reason for doing so?
Regards,
Owen
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]