Re: Outstanding patches, #50187



"Matthias Clasen" <matthiasc poet de> writes:

> The comment for this patch says:
> 
> Makes .ICO loader more robust, minor fix for JPEG, and test images for wbmp
> 
> I don't include the patch, since it is large. If you want to review it, go
> to
> 
> http://bugzilla.gnome.org/showattachment.cgi?attach_id=737
> 
> Ok to commit ?

I spent a bit of time going over this, and found a bunch more buffer
overflows in the ICO loader beyond what was found here. It certainly
isn't a full fix.

The patch, however, does look like it is a fairly big improvement, so
why don't you go ahead and commit it.

Regards,
                                        Owen




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]