Re: gtkstock fixes and other comments

[Owen Taylor <otaylor redhat com>]

Havoc Pennington <hp redhat com> writes:

> Paolo Molaro <lupus lettere unipd it> writes:
> > I think there is a bug in the gtkstock implementation:
> > the stock label is translated at each lookup of the stock
> > item (unnecessary, IMHO, and could well get called on the
> > already translated string)
> 
> It couldn't, the GtkStockItem is defined to contain the untranslated
> string. Though I don't think there's any problem with the optimization
> of calling it when the item is inserted in the hash, if you want to
> apply that patch it should be fine.

Since most apps won't use all stock item labels, doing it lazily
is a definite win. Also, even if they are all used, avoiding
startup overhead is a good thing. I think the original method
is better.

Regards,
                                        Owen