Re: Gtk Rtl patch



On 21 Oct 2000, Owen Taylor wrote:

> > +      if (gtk_widget_get_direction(range) == GTK_TEXT_DIR_RTL)
> > +	x = right - (x - left);
> > +      
> 
> Are you sure this doesn't mess up scrollbars, which definitely
> should not flip? You may have to do something in Gtk[HV]Scale
> instead if that is a problem, or make a class flag indicating
> whether the flipping should be done. 

Argh. So it does. How does this sound - 
  add guint flippable : 1; to GtkRange, initialise this to 0 in
  gtk_range_new, have the flipping be conditional on this, and have
  GtkHScale's _new set it to 1.

-- 
I speak for myself, not my employer






[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]