Re: Patch for iconv-impaired systems

[Sebastian Wilhelmi <wilhelmi ira uka de>]

Hi James,

> > recently I tried to compile GLib on aome platform (I forgot which) without
> > iconv. I will commit the following patch, if noone objects:
> >
> > Now g_convert_* just throws an error, if called on a platfrom without iconv.
> > That makes GLib at least compile. It might however be a good idea to at least
> > implement some basic and often wanted conversions explicity on such platforms
> > later.
> >
> > The guard for including iconv.h is HAVE_ICONV and not HAVE_ICONV_H, because I
> > hope, that UNIX has learned its leassons and now standardize the header names
> > as well, i.e. "iconv exists iff iconv.h exists and has the prototype".
> >
> > The patch is attached.
> 
> I was under the impression that an iconv implementation was requirement
> now.  This could either be the system iconv or a third party one such as
> libiconv.

Maybe, but then we should at least test for the presense of iconv (in -liconv,
if not
in -lc) and stop with error, if not found and additionally add it to the
required libs for linking (i.e. `glib-config-2.0 --libs`), if not in -lc

Bye,
Sebastian
-- 
Sebastian Wilhelmi
mailto:wilhelmi ira uka de
http://goethe.ira.uka.de/~wilhelmi