Re: stock system

[Tim Janik <timj gtk org>]

On 26 Jul 2000, Havoc Pennington wrote:

> 
> Hi,
> 
> This is just the stock icon system, more or less. It has
> interdependencies with the other stuff, but these are the main stock
> icon files.
> 
> See ChangeLog from the appended patch, and my earlier post on the RC
> file format, for details.
> 
> In particular:
> 
> +	* gtk/gtkiconfactory.h, gtk/gtkiconfactory.c: New icon system. Three 
> +	important types:
> +
> +	(GtkIconSource): Specification for creating a pixbuf 
> +	appropriate for a direction/state/size triplet from 
> +	a source pixbuf or filename
> +
> +	(GtkIconSet): List of GtkIconSource that used to create

s/used/are used/ ?

> +	the "same" icon (e.g. an OK button icon), and cache 
> +	for rendered icons

rendered? i.e. scaling?
is the caching behaviour exposed, i mean can we change that to
use adequat pixbuf caching API in the future?

> +	(GtkIconFactory): Hash from stock ID to GtkIconSet; used to look

what exactly is a stock ID?

> +	up the icon set for a given stock ID.  GTK maintains a stack of
> +	GtkIconFactory to search, and applications or libraries can add

s/GtkIconFactory/GtkIconFactory objects/ ?

> +	additional icon factories on top of the stack

how's the stack ordered? FIFO? if that's the case (the term "stack"
indicates that), shouldn't we use something similar to the key binding
priorities here to let users (or desktop distributors) override
application factories?

> 
> Havoc
> 
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/gtk+/ChangeLog,v
> retrieving revision 1.1358
> diff -u -u -r1.1358 ChangeLog
> --- ChangeLog	2000/07/26 11:32:23	1.1358
> +++ ChangeLog	2000/07/26 22:00:32
> @@ -1,3 +1,63 @@
> +2000-07-26  Havoc Pennington  <hp@redhat.com>
> +
> +        * gtk/gtkrc.h, gtk/gtkrc.c: When loading an RcStyle, parse 
> +	the set of GtkIconSource specified for a given stock ID into 
> +	a GtkIconSet, and put the GtkIconSet into a GtkIconFactory for the 
> +	RcStyle, under the specified stock ID.
> +
> +	* gtk/gtkstyle.h, gtk/gtkstyle.c: Add a virtual function
> +	render_icon used to derive a GdkPixbuf from a GtkIconSource.

"derive" ? now what's "render"ing exactly here? ;)

> +	This allows people to theme how prelight, insensitive, etc. are
> +	done.
[...]

> +	* gtk/gtkstock.h, gtk/gtkstock.c: Header with the GtkStockItem type
> +	(contains information about a stock item), the built-in stock item
> +	IDs, and functions to add/lookup stock items.

can you elaborate on what makes up a "stock item", conceptually?

[...]

i'd like to sort these things out before diving into the patch.

---
ciaoTJ