Re: chubbiness reduction

["Daniel Richard G." <straker fox mit edu>]

On Tue, 11 Jul 2000, Tim Janik wrote:

> ok, the rc files can contain thicknesses now, with that, you are able
> to specify default style attributes per widget class:
> 
> style "buttonthickness" {
>   xthickness = 1
>   ythickness = 1
> }
> class "GtkButton" style "buttonthickness"

Okay, I missed that. That looks reasonable.

The only issue I'd point out is (mostly) academic: specifying thicknesses
this way sort of implies that general widget geometry parameters-- those
currently specified using class variables-- should be too, being a property
of the same kind. That is, if consistency is the goal, one would expect to
also be able to do e.g.:

style "scale" {
	slider_length = 20
	value_spacing = 5
}
class "GtkScake" style "scale"

Not to say there's an immediate need for this, but only that the disparity
in how {x,y}thickness and geometry parameters are handled/specified ought
to be resolved. Having everything in gtkrc is one good way of going about
it, albeit probably not the easiest one (every would will have to implement
some GScanner parsing magic, etc.), so you'd be setting yourself up for a
lot of work over the course of the next stable series. 

(as opposed to, say, doing everything through class variables-- which works
fine for me. That would, however, practically make geometry modifications
the sole domain of theme engines) 

> now, we still need someone going through the code and fixing up widgets
> that don't properly respect thickness settings, e.g. scrollbars, frame...

For the record, I believe Gtk{H,V}Scrollbar and GtkFrame do use thickness
values properly... although in the former case, if you have inconsistent
values for stepper_size and slider_width, you do get ugly results.

> also gtkstyle.c prolly needs to be fixed in some places where it assumes
> the thickness either is 2 or is at least 2.
> 
> ---
> ciaoTJ


--Straker


                       //,,    //,,
//=================// //////  ////// //==================================\\
 Straker Skunk     / //////  ////// /      Skunks are such wonderful
 <skunk@mit.edu>  / //////  ////// /     creatures... soft, and cuddly,
 -- -- -- -- -- --\ \\\\\\  \\\\\\ \      and if you annoy them they
 Daniel Richard G. \ \\\\\\  \\\\\\ \      make you stink like hell
 ========--====--==-\ \\\\\\  \\\\\\ \---------------=--==--====--========
 //mit.edu/straker  / //////  ////// / Furry|Course VI-3|MIT Class of 2001
 //skunk.mit.edu   / //////  ////// / 80% Beaver 90% Penguin 100% SKUNK!!!
\\===============// //////  ////// //====================================//
                     ''//    ''//