Re: non-attached style detached in gtkinvisible.

Alexander Larsson <alla lysator liu se> writes:

> On Mon, 18 Dec 2000, Alexander Larsson wrote:
> > Ok, this was a sucker to track down.
> >
> > Destroying a GtkInvisible eventually results in it becoming unrealized and
> > it's widget->style to be detached. But gtk_invisible_realize doesn't
> > attach the style (it really doesn't need any frickin style), this makes
> > the widget style attach counter to decrease by one each time a
> > GtkInvisible is unrealized, and eventually the style will be destroyed
> > while there are still references to it.
> >
> > Here is a patch that just attaches the style. This is a bit wasteful,
> > since it is not needed, but it is a simple way to fix the problem.
> >
> > This bug is probably in Gtk+ 1.2.x too.


> No comments?
> Is it ok to check in this?

It looks good. Please check this in to both HEAD and the gtk-1-2
branch of GTK+.

(I'm not so sure that your usage of GtkInvisible in the GtkWindow
code is appropriate - I'll try to read that over in detail and get
comments to you on that today.)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]