Re: Disabling memory chunks and free list in glib



On Mon, 18 Dec 2000, Tim Janik wrote:

> On Mon, 18 Dec 2000, Alexander Larsson wrote:
>
> > I don't know if this is the correct way to to this, as by disabling the
> > memchunk code the application developer cannot use mem chunks either. On
> > the other hand it is a lot cleaner that going through all GMemChunk users
> > in glib and gtk+.
>
> i think this is the right thign to do. if the application wants to be perfectly
> suited for a system with sparse memory, it's probably not going to use memchunks
> anyways, the main concern here is to get rid of wastefull behaviour in the
> underlying libraries, which your patch takes care off.

I agree.

> jup, they went below.
> this can go into cvs once you fixed g_nodes_free().
> could you resend me your malloc-virtualization patch btw?
> i'm not sure what the last version was.

Well, since nobody seemed to care i kinda dropped them. I'll see if i can
find them and freshen them up a bit.

> > +static void
> > +g_nodes_free (GNode *node)
> > +{
> > +  g_free (node);
> > +}
> > +#endif
>
> huh?
> g_nodes_free() frees ->children recursively and walks node->next!

Sorry about that. I plead incompetence, but I blame society.

/ Alex






[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]